Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for global memory control #10908

Merged
merged 13 commits into from
Nov 7, 2022
Merged

Add docs for global memory control #10908

merged 13 commits into from
Nov 7, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Add docs for global memory control

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022
@TomShawn TomShawn marked this pull request as draft October 19, 2022 09:41
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Oct 19, 2022
@TomShawn TomShawn removed the request for review from shichun-0415 October 20, 2022 09:26
TomShawn
TomShawn commented Oct 21, 2022
View reviewed changes
configure-memory-usage.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage-ops-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Oct 21, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Oct 21, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn TomShawn marked this pull request as ready for review October 21, 2022 05:07
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@TomShawn TomShawn requested review from wshwsh12 and hfxsd October 21, 2022 05:07
hfxsd
hfxsd reviewed Oct 24, 2022
View reviewed changes
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Oct 24, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Oct 31, 2022
View reviewed changes
configure-memory-usage.md Outdated Show resolved Hide resolved
@TomShawn TomShawn requested a review from hfxsd October 31, 2022 02:31
hfxsd
hfxsd approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

configure-memory-usage.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage-ops-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-memory-usage.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
XuHuaiyu
XuHuaiyu reviewed Nov 4, 2022
View reviewed changes
system-variables.md Outdated

- Scope: GLOBAL
- Persists to cluster: Yes
- Default value: 80%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0

TomShawn
TomShawn commented Nov 4, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor Author

TomShawn commented Nov 7, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad2979f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit f32fc0e into pingcap:master Nov 7, 2022
@TomShawn TomShawn deleted the global-memory-limit-6.4 branch November 7, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

@TomShawn TomShawn

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-chi-bot @XuHuaiyu @wshwsh12 @hfxsd