Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ran <[email protected]>
  • Loading branch information
2 people authored and ti-chi-bot committed Sep 8, 2023
1 parent c8af8fb commit 1594aa1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dm/dm-binlog-event-filter.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Starting from DM v2.0.2, you can configure the binlog event filter in the source
When you use the wildcard for matching schemas and tables, note the following:
- `schema-pattern` and `table-pattern` only support wildcards including `*`, `?` and `[]`. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.
- `schema-pattern` and `table-pattern` only support wildcards, including `*`, `?`, and `[]`. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.

- `sql-pattern` only supports regular expressions.

Expand Down
2 changes: 1 addition & 1 deletion dm/dm-block-allow-table-lists.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ block-allow-list: # Use black-white-list if the DM version is earlie
In simple scenarios, it is recommended that you use the wildcard for matching schemas and tables. However, note the following version differences:
- Wildcards including `*`, `?` and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `tbl-name: "t*"`, `"t*"` indicates all tables starting with `t`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.
- Wildcards including `*`, `?`, and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `tbl-name: "t*"`, `"t*"` indicates all tables starting with `t`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.

- A regular expression must begin with the `~` character.

Expand Down
2 changes: 1 addition & 1 deletion dm/dm-table-routing.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ routes:
Regular expressions and wildcards are supported to match database and table names. In simple scenarios, it is recommended that you use the wildcard for matching schemas and tables. However, note the following:
- Wildcards including `*`, `?` and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.
- Wildcards including `*`, `?`, and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details.

- `table-regexp`, `schema-regexp`, and `source-regexp` only support regular expressions and cannot start with the `~` symbol.

Expand Down

0 comments on commit 1594aa1

Please sign in to comment.