Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: update doc for deploying TiDB cluster on ACK (#62) #105

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020

cherry-pick #62 to release-1.1


What is changed, added or deleted? (Required)

Update doc for deploying TiDB cluster on Alibaba cloud.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version, including v1.1 changes for now)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

* en: update doc for deploying TiDB cluster on ACK

* Apply suggestions from Daniel

Co-Authored-By: DanielZhangQD <[email protected]>

* address comments from Daniel

* Apply suggestions from code review

Co-Authored-By: DanielZhangQD <[email protected]>

* address comments from Coco

Co-Authored-By: Keke Yi <[email protected]>

* move the destroy section

Co-authored-by: DanielZhangQD <[email protected]>
Co-authored-by: Keke Yi <[email protected]>
@sre-bot sre-bot added type/cherry-pick-for-release-1.1 This PR is cherry-picked to release-1.1 from a source PR. v1.1 This PR/issue applies to TiDB Operator v1.1. labels Mar 30, 2020
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 79793ee into pingcap:release-1.1 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/cherry-pick-for-release-1.1 This PR is cherry-picked to release-1.1 from a source PR. v1.1 This PR/issue applies to TiDB Operator v1.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants