Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

*: update tidb-server download URL #611

Merged
merged 2 commits into from
Apr 9, 2021
Merged

*: update tidb-server download URL #611

merged 2 commits into from
Apr 9, 2021

Conversation

lance6716
Copy link
Contributor

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2021
@CharLotteiu
Copy link
Contributor

/label needs-cherry-pick-2.0
/status PTAL
/translation no-need
/cc @CharLotteiu @GMHDBJD

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 8, 2021
CharLotteiu
CharLotteiu approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2021
GMHDBJD
GMHDBJD approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2021
@CharLotteiu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a287af0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@ti-chi-bot ti-chi-bot merged commit dc5f402 into pingcap:master Apr 9, 2021
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Apr 9, 2021
@lance6716 @ti-srebot
cherry pick pingcap#611 to release-2.0
6d9940a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #618

ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
*: update tidb-server download URL (#611) (#618)
ca37f6e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CharLotteiu CharLotteiu CharLotteiu approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @CharLotteiu @ti-chi-bot @ti-srebot @GMHDBJD