This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
support using task-file when need task-name #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/label needs-cherry-pick-1.0, size/small, v1.0, v2.0, version-specific-changes-required, translation/from-zh |
ti-srebot
added
needs-cherry-pick-release-1.0
Should cherry pick this PR to release-1.0 branch.
size/small
Changes of a small size.
translation/from-zh
This PR is translated from a PR in docs-dm/zh.
v1.0
This PR/issue applies to TiDB DM v1.0.
v2.0
This PR/issue applies to TiDB DM v2.0.
requires-version-specific-changes
After cherry-picked, the cherry-picked PR requires further changes.
labels
Aug 19, 2020
/cc lance6716, lilin90 |
LGTM |
@lance6716,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
lilin90
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
pushed a commit
to ti-srebot/docs-dm
that referenced
this pull request
Aug 19, 2020
Signed-off-by: ti-srebot <[email protected]>
6 tasks
cherry pick to release-1.0 in PR #258 |
lilin90
added a commit
that referenced
this pull request
Aug 19, 2020
* cherry pick #257 to release-1.0 Signed-off-by: ti-srebot <[email protected]> * Delete dmctl-introduction.md * Delete pause-task.md * Delete resume-task.md * Delete stop-task.md * Update manage-replication-tasks.md * Update quotation marks to "quotes" Co-authored-by: JoyinQ <[email protected]> Co-authored-by: Lilian Lee <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-cherry-pick-release-1.0
Should cherry pick this PR to release-1.0 branch.
requires-version-specific-changes
After cherry-picked, the cherry-picked PR requires further changes.
size/small
Changes of a small size.
status/LGT1
Indicates that a PR has LGTM 1.
translation/from-zh
This PR is translated from a PR in docs-dm/zh.
v1.0
This PR/issue applies to TiDB DM v1.0.
v2.0
This PR/issue applies to TiDB DM v2.0.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
support using task-file when need task-name
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?