Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequence: remove the order keyword of sequence #7417

Merged
merged 2 commits into from
Nov 19, 2021
Merged

sequence: remove the order keyword of sequence #7417

merged 2 commits into from
Nov 19, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Nov 5, 2021 •
edited
Loading

Signed-off-by: ailinkid [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):
  • Attention

There are nothing change about the code (since this order keyword hasn't existed since the very beginning), which means this pr is just a doc revisement.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 5, 2021 03:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2021
@AilinKid AilinKid changed the title sequence: remove the order of sequence sequence: remove the order keyword of sequence Nov 5, 2021
@AilinKid AilinKid requested a review from bb7133 November 5, 2021 03:07
@ti-chi-bot
Copy link
Member

@djshow832: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn self-assigned this Nov 5, 2021
@TomShawn TomShawn added needs-cherry-pick-release-4.0 area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 5, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@AilinKid: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 8, 2021

@TomShawn pls help merge it

@TomShawn TomShawn added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Nov 19, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e08f394

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2021
@TomShawn
Copy link
Contributor

/merge

@TomShawn TomShawn merged commit e44163e into pingcap:master Nov 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7556.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7557.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7558.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7559.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7560.

ti-chi-bot added a commit that referenced this pull request Nov 19, 2021
@ti-chi-bot
sequence: remove the order keyword of sequence (#7417) (#7556)
74424b8
ti-chi-bot added a commit that referenced this pull request Nov 19, 2021
@ti-chi-bot
sequence: remove the order keyword of sequence (#7417) (#7559)
4b2b57d
ti-chi-bot added a commit that referenced this pull request Nov 19, 2021
@ti-chi-bot
sequence: remove the order keyword of sequence (#7417) (#7558)
0c5045d
ti-chi-bot added a commit that referenced this pull request Nov 19, 2021
@ti-chi-bot
sequence: remove the order keyword of sequence (#7417) (#7557)
cd42e69
ti-chi-bot added a commit that referenced this pull request Nov 19, 2021
@ti-chi-bot
sequence: remove the order keyword of sequence (#7417) (#7560)
ed9e671
@TomShawn TomShawn mentioned this pull request Nov 25, 2021
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2021
This was referenced Nov 25, 2021
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@djshow832 djshow832 djshow832 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@TomShawn TomShawn

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @ti-chi-bot @TomShawn @djshow832