Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the hint LIMIT_TO_COP() #7202

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Add the hint LIMIT_TO_COP() #7202

merged 5 commits into from
Sep 27, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 27, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Add the hint LIMIT_TO_COP()

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 27, 2021 06:39
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021
@ti-chi-bot
Copy link
Member

@winoros: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ichn-hu
ichn-hu approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

optimizer-hints.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@ichn-hu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Sep 27, 2021
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@TomShawn TomShawn closed this Sep 27, 2021
@TomShawn TomShawn reopened this Sep 27, 2021
TomShawn
TomShawn reviewed Sep 27, 2021
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@TomShawn TomShawn self-assigned this Sep 27, 2021
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-5.1 area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. and removed missing-translation-status This PR does not have translation status info. labels Sep 27, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn September 27, 2021 08:53
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. translation/doing This PR’s assignee is translating this PR. and removed sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Sep 27, 2021
@TomShawn
Copy link
Contributor

/verify

@TomShawn TomShawn closed this Sep 27, 2021
@TomShawn TomShawn reopened this Sep 27, 2021
@TomShawn
Copy link
Contributor

/verify

@TomShawn TomShawn merged commit 49472f9 into pingcap:master Sep 27, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 27, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7205.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 27, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7207.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 27, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7210.

TomShawn added a commit that referenced this pull request Sep 27, 2021
@ti-chi-bot @qw4990
@TomShawn @ichn-hu
Add the hint LIMIT_TO_COP() (#7202) (#7205)
8fa8048 
* add hint LIMIT_TO_COP()

* update

* Update optimizer-hints.md

Co-authored-by: 虎 <[email protected]>

* Update optimizer-hints.md

* Update optimizer-hints.md

* Update optimizer-hints.md

Co-authored-by: Yuanjia Zhang <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: 虎 <[email protected]>
TomShawn added a commit that referenced this pull request Sep 27, 2021
@ti-chi-bot @qw4990
@TomShawn @ichn-hu
Add the hint LIMIT_TO_COP() (#7202) (#7207)
fe7d174 
* add hint LIMIT_TO_COP()

* update

* Update optimizer-hints.md

Co-authored-by: 虎 <[email protected]>

* Update optimizer-hints.md

* Update optimizer-hints.md

* Update optimizer-hints.md

Co-authored-by: Yuanjia Zhang <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: 虎 <[email protected]>
ti-chi-bot added a commit that referenced this pull request Sep 27, 2021
@ti-chi-bot
Add the hint LIMIT_TO_COP() (#7202) (#7210)
96b87ac
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 28, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7215.

ti-chi-bot added a commit that referenced this pull request Sep 28, 2021
@ti-chi-bot
Add the hint LIMIT_TO_COP() (#7202) (#7215)
3cae3e5
@TomShawn TomShawn mentioned this pull request Nov 25, 2021
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2021
This was referenced Nov 25, 2021
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@winoros winoros winoros approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-chi-bot @TomShawn @winoros @ichn-hu