Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tidb-lightning-faq.md from OnCALL #7197

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Update tidb-lightning-faq.md from OnCALL #7197

merged 4 commits into from
Nov 18, 2021

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 27, 2021 05:13
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021
@lance6716
Copy link
Contributor Author

/cc @glorv

@ti-chi-bot ti-chi-bot requested a review from glorv September 27, 2021 05:15
@knull-cn
Copy link
Contributor

LGTM

1 similar comment
@glorv
Copy link
Contributor

glorv commented Sep 27, 2021

LGTM

@TomShawn TomShawn requested a review from hfxsd September 27, 2021 12:06
@TomShawn TomShawn added needs-cherry-pick-release-5.1 area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Sep 27, 2021
@hfxsd hfxsd mentioned this pull request Nov 18, 2021
Merged
13 tasks
@hfxsd hfxsd added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 18, 2021
@TomShawn TomShawn added the ONCALL Relates to documentation oncall. label Nov 18, 2021
@hfxsd hfxsd removed the translation/doing This PR’s assignee is translating this PR. label Nov 18, 2021
hfxsd
hfxsd approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
glorv
glorv reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liuxiaozhen12
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2021
@Liuxiaozhen12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 509195b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@ti-chi-bot ti-chi-bot merged commit 8ea8909 into master Nov 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7531.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7532.

ti-chi-bot added a commit that referenced this pull request Nov 18, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#7197) (#7531)
c0f6595
ti-chi-bot added a commit that referenced this pull request Nov 18, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#7197) (#7532)
3882c03
This was referenced Nov 19, 2021
Merged
Merged
Merged
Merged
@TomShawn TomShawn deleted the lance6716-patch-3 branch November 22, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@glorv glorv glorv left review comments

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@hfxsd hfxsd

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lance6716 @ti-chi-bot @knull-cn @glorv @Liuxiaozhen12 @hfxsd @TomShawn