Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiFlash io rate limit configuration. #6820

Merged
merged 23 commits into from
Aug 13, 2021
Merged

TiFlash io rate limit configuration. #6820

merged 23 commits into from
Aug 13, 2021

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Aug 6, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add configuration for TiFlash io rate limit.

This feature is GA in v5.2.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Aug 6, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 6, 2021 03:41
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2021
@JinheLin
Copy link
Contributor Author

JinheLin commented Aug 6, 2021

/cc @flowbehappy

@ti-chi-bot ti-chi-bot requested a review from flowbehappy August 6, 2021 03:44
@TomShawn
Copy link
Contributor

TomShawn commented Aug 6, 2021 •
edited
Loading

@JinheLin Please sign the Contributor License Agreement. If this PR is v5.2 related, please add the v5.2 label. Thanks!

@JinheLin
Copy link
Contributor Author

JinheLin commented Aug 6, 2021 •
edited
Loading

@JinheLin Please sign the Contributor License Agreement. If this PR is v5.2 related, please add the v5.2 label. Thanks!

image

I have signed tha CLA. And I don't have permission to add a lable. @TomShawn

@TomShawn
Copy link
Contributor

TomShawn commented Aug 6, 2021 •
edited
Loading

@JinheLin Please click this button. If it is v5.2-related, please specify in the PR description part and I'll add the label. Thanks!
image

@JinheLin
Copy link
Contributor Author

JinheLin commented Aug 6, 2021 •
edited
Loading

@JinheLin Please click this button. If it is v5.2-related, please specify in the PR description part and I'll add the label. Thanks!
image

I have clicked this button. You can see my screenshot above: "You have agreed to the CLA for pingcap/docs-cn".

And I have update the PR description part: "This feature is GA in v5.2". Please add a v5.2 label for it. @TomShawn

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. labels Aug 6, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 6, 2021
@TomShawn TomShawn removed the v5.2 This PR/issue applies to TiDB v5.2. label Aug 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Aug 6, 2021

/label v5.2

@ti-chi-bot ti-chi-bot added the v5.2 This PR/issue applies to TiDB v5.2. label Aug 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Aug 6, 2021

/label v5.1

@ti-chi-bot ti-chi-bot added the v5.1 This PR/issue applies to TiDB v5.1. label Aug 6, 2021
@TomShawn TomShawn removed the v5.1 This PR/issue applies to TiDB v5.1. label Aug 6, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2021
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 9, 2021
flowbehappy
flowbehappy approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@flowbehappy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

SE-Bin
SE-Bin reviewed Aug 12, 2021
View reviewed changes
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
@SE-Bin
Copy link
Contributor

SE-Bin commented Aug 13, 2021

LGTM

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a27320f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot ti-chi-bot merged commit 596898a into pingcap:master Aug 13, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 16, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 16, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Aug 26, 2021
Closed
@JaySon-Huang
Copy link
Contributor

Related feature issue: pingcap/tiflash#1720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SE-Bin SE-Bin SE-Bin left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JinheLin @ti-chi-bot @CLAassistant @TomShawn @qiancai @SE-Bin @JaySon-Huang @flowbehappy @en-jin19