Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for TiDB specific SQL functions #6520

Merged
merged 10 commits into from
Jul 5, 2021
Merged

Add documentation for TiDB specific SQL functions #6520

merged 10 commits into from
Jul 5, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

Add documentation for SQL functions TIDB_PARSE_TSO and TIDB_BOUNDED_STALENESS.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 24, 2021 08:16
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-5.1
/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-5.0 and removed missing-translation-status This PR does not have translation status info. labels Jun 24, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from JmPotato June 24, 2021 08:36
TomShawn
TomShawn reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comments:

  • "TiDB 的特有函数" --> "TiDB 特有的函数"
  • ".. 函数可以用来.." --> ".. 函数用于.."

TOC.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jun 28, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from TomShawn July 1, 2021 02:30
TomShawn
TomShawn reviewed Jul 5, 2021
View reviewed changes
functions-and-operators/tidb-functions.md Outdated

## TIDB_DECODE_KEY

`TIDB_DECODE_KEY` 函数可用于将 TiDB 编码的键输入解码为包含 `_tidb_rowid` 和 `table_id` 的 JSON 结构。你可以在一些系统表和日志输出中找到 TiDB 的编码键。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comment: "可用于" --> "用于"

TomShawn
TomShawn approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

@JmPotato PTAL, thanks!

@ti-chi-bot
Copy link
Member

@JmPotato: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b90702b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit ccecf6c into pingcap:master Jul 5, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@Liuxiaozhen12 @ti-chi-bot
Add documentation for TiDB specific SQL functions (pingcap#6520)
3d86978
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6611.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@Liuxiaozhen12 @ti-chi-bot
Add documentation for TiDB specific SQL functions (pingcap#6520)
dbbe459
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6612.

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 5, 2021
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Add documentation for TiDB specific SQL functions (#6520) (#6611)
f2c2965
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Add documentation for TiDB specific SQL functions (#6520) (#6612)
5c41837
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@Liuxiaozhen12 @3AceShowHand
Add documentation for TiDB specific SQL functions (pingcap#6520)
c39f98d
@Liuxiaozhen12 Liuxiaozhen12 deleted the Liuxiaozhen-patch-1 branch September 26, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn @JmPotato