Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command to check tikv user #6502

Merged
merged 15 commits into from
Jul 8, 2021
Merged

add command to check tikv user #6502

merged 15 commits into from
Jul 8, 2021

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Jun 23, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add 2 alternative way to check tiki user

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • [ x] Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 23, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 23, 2021 07:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2021
@TomShawn TomShawn requested a review from 3pointer June 23, 2021 07:57
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. labels Jun 23, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 23, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Jun 23, 2021

/cc @3pointer @Zwj-coder

@ti-chi-bot ti-chi-bot requested a review from ZipFast June 23, 2021 08:07
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • zwj-coder

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2021
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
br/backup-and-restore-faq.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 7, 2021
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed status/require-change Needs the author to address comments. labels Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 367ff78

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 8fcd249 into pingcap:master Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 19, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 19, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@fengou1 @3AceShowHand
add command to check tikv user (pingcap#6502)
a45cf0b
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer left review comments

@TomShawn TomShawn TomShawn approved these changes

@Leavrth Leavrth Leavrth approved these changes

@ZipFast ZipFast ZipFast approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fengou1 @ti-chi-bot @TomShawn @3pointer @ZipFast @Leavrth @Liuxiaozhen12