Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tidb_memory_usage_alarm_ratio scope to instance #6409

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Change tidb_memory_usage_alarm_ratio scope to instance #6409

merged 3 commits into from
Jul 6, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Jun 4, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@wshwsh12 wshwsh12 requested a review from XuHuaiyu June 4, 2021 10:20
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 4, 2021 10:20
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2021
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 4, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 4, 2021
crazycs520
crazycs520 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jul 6, 2021

Is there a related PR in TiDB?

TomShawn
TomShawn reviewed Jul 6, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Jul 6, 2021

related PR in TiDB?

@XuHuaiyu We can see the variable is in process global variables list.
https://github.com/pingcap/tidb/blob/7259784c683c44841ffb4cd202ed96ac0d4738ca/sessionctx/variable/tidb_vars.go#L744
I did not modify the logic of tidb, but just corrected the document.

TomShawn
TomShawn approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bf820a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@ti-chi-bot ti-chi-bot merged commit 47de914 into pingcap:master Jul 6, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6621.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 6, 2021
@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#6409
8a9a6be 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2021
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 6, 2021
@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#6409
82239a7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6622.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 6, 2021
@wshwsh12 @ti-chi-bot
Change tidb_memory_usage_alarm_ratio scope to instance (pingcap#6409)
1ad8a0e
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6623.

ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
@ti-chi-bot
Change tidb_memory_usage_alarm_ratio scope to instance (#6409) (#6623)
63b45d5
ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
@ti-chi-bot
Change tidb_memory_usage_alarm_ratio scope to instance (#6409) (#6621)
839eb90
ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
@ti-chi-bot
Change tidb_memory_usage_alarm_ratio scope to instance (#6409) (#6622)
6e768ed
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 16, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2021
This was referenced Jul 16, 2021
Merged
Merged
Merged
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@wshwsh12 @3AceShowHand
Change tidb_memory_usage_alarm_ratio scope to instance (pingcap#6409)
8787ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wshwsh12 @XuHuaiyu @ti-chi-bot @TomShawn @crazycs520 @Liuxiaozhen12