Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description about hot-region-cache-hits-threshold #6339

Merged
merged 2 commits into from
May 28, 2021
Merged

Fix description about hot-region-cache-hits-threshold #6339

merged 2 commits into from
May 28, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 26, 2021 •
edited by TomShawn
Loading

Signed-off-by: yisaer [email protected]

What is changed, added or deleted? (Required)

Fix description about hot-region-cache-hits-threshold

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Yisaer
revise
ebc021f 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 26, 2021 08:40
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2021
@TomShawn TomShawn requested review from nolouch and Ishiihara May 26, 2021 08:43
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels May 26, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 26, 2021
@ti-chi-bot
Copy link
Member

@lhy1024: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed May 27, 2021
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
@Yisaer @TomShawn
Update pd-control.md
eb5a112 
Co-authored-by: TomShawn <[email protected]>
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 28, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb5a112

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2021
@ti-chi-bot ti-chi-bot merged commit 95f247a into pingcap:master May 28, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6363.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6364.

@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2021
Merged
10 tasks
ti-chi-bot added a commit that referenced this pull request May 28, 2021
@ti-chi-bot
Fix description about hot-region-cache-hits-threshold (#6339) (#6363)
6b46eb7
ti-chi-bot added a commit that referenced this pull request May 28, 2021
@ti-chi-bot
Fix description about hot-region-cache-hits-threshold (#6339) (#6364)
15ec500
@Joyinqin Joyinqin mentioned this pull request May 31, 2021
Merged
12 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 31, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #6339 on top of branch "release-4.0":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #6339 on top of branch "release-5.0":

failed to git commit: exit status 1

This was referenced May 31, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees

@Joyinqin Joyinqin

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @TomShawn @Joyinqin @lhy1024