Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: add more docs about unified sorter #6258

Merged
merged 5 commits into from
May 28, 2021

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented May 13, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 13, 2021 06:58
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2021
@overvenus
Copy link
Member Author

/cc @liuzix @amyangfei @TomShawn

@ti-chi-bot ti-chi-bot requested review from amyangfei and liuzix May 13, 2021 06:59
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels May 13, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 13, 2021
@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label May 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2021
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 14, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/deploy-ticdc.md Outdated Show resolved Hide resolved
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 095771b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2021
@ti-chi-bot ti-chi-bot merged commit 068d8ad into pingcap:master May 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6365.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6366.

@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs-cn#release-4.0 from head ti-chi-bot:cherry-pick-6258-to-release-4.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-6258-to-release-4.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6369.

@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs-cn#release-4.0 from head ti-chi-bot:cherry-pick-6258-to-release-4.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-6258-to-release-4.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants