Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clustered-indexes.md #5771

Merged
merged 10 commits into from
Mar 23, 2021
Merged

Update clustered-indexes.md #5771

merged 10 commits into from
Mar 23, 2021

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 18, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the user documentation of clustered index feature introduced in v5.0-rc & v5.0.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2021
@tangenta
Copy link
Contributor Author

/cc @coocood @lysu

@ti-chi-bot ti-chi-bot requested review from coocood and lysu March 18, 2021 08:25
tangenta
tangenta commented Mar 18, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
tangenta
tangenta commented Mar 18, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
tangenta
tangenta commented Mar 18, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
tangenta
tangenta commented Mar 18, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
coocood
coocood reviewed Mar 18, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/assign @CharLotteiu
/label v5.0
/translation doing
/status PTAL
/size large
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. status/PTAL This PR is ready for reviewing. size/large Changes of a large size. v5.0 This PR/issue applies to TiDB v5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Mar 18, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0

@coocood
Copy link
Member

coocood commented Mar 18, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@coocood: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@tangenta tangenta mentioned this pull request Mar 18, 2021
Merged
11 tasks
tangenta and others added 2 commits March 19, 2021 17:38
TomShawn
TomShawn reviewed Mar 19, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@lysu, @qiancai, PTAL.

qiancai
qiancai reviewed Mar 22, 2021
View reviewed changes
clustered-indexes.md Outdated
Records: 2 Duplicates: 0 Warnings: 0
- 明确不支持且没有支持计划的使用限制：
- 不支持与 TiDB Binlog 一起使用。开启 TiDB Binlog 后 TiDB 不允许创建非单个整数列作为主键的聚簇索引；已创建的聚簇索引表的数据插入、删除和更新动作不会通过 Binlog 同步到下游。如需同步聚簇索引表，请使用 [TiCDC](/ticdc/ticdc-overview.md)。
- 不支持与 `SHARD_ROW_ID_BITS` 一起使用。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.google.com/document/d/1AgqZtzXr1Oqdbq_eNdPohE2tEoqE2mgQ11SsadSXQWw/edit# 里提到了 “聚簇索引不支持与 SHARD_ROW_ID_BITS,AUTO_RANDOM，PRE_SPLIT_REGIONS 属性一起使用。”， 所以这里是否需要补充 AUTO_RANDOM，PRE_SPLIT_REGIONS 属性。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRE_SPLIT_REGIONS 描述已更新。关于 AUTO_RANDOM 属性的描述已更新在文档最下方。

@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7254b54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@ti-chi-bot ti-chi-bot merged commit 6876ad2 into pingcap:master Mar 23, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 23, 2021
@ti-srebot
cherry pick pingcap#5771 to release-5.0
52b140a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5805

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
Update clustered-indexes.md (#5771) (#5805)
03cf8be
@tangenta tangenta mentioned this pull request Mar 25, 2021
Merged
11 tasks
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
11 tasks
@CharLotteiu CharLotteiu mentioned this pull request Mar 26, 2021
Merged
10 tasks
@CharLotteiu
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 26, 2021
@tangenta tangenta mentioned this pull request Mar 29, 2021
Merged
11 tasks
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@TomShawn TomShawn TomShawn left review comments

@yikeke yikeke yikeke left review comments

@coocood coocood coocood left review comments

@lysu lysu Awaiting requested review from lysu

Assignees

@CharLotteiu CharLotteiu

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tangenta @TomShawn @coocood @ti-chi-bot @lysu @qiancai @ti-srebot @CharLotteiu @yikeke