Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details for Hexadecimal Literals #5620

Merged
merged 12 commits into from
Apr 20, 2021
Merged

Add details for Hexadecimal Literals #5620

merged 12 commits into from
Apr 20, 2021

Conversation

zoujia-cm
Copy link

@zoujia-cm zoujia-cm commented Feb 26, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • The PR is translated from:

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 26, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn
Copy link
Contributor

@zoujia-cm Thanks for your contribution! Could you please sign the Contributor License Agreement for this PR to be merged?

@TomShawn TomShawn changed the title Update literal-values.md Add details for Hexadecimal Literals Mar 1, 2021
@TomShawn TomShawn requested a review from XuHuaiyu March 1, 2021 06:24
@TomShawn TomShawn added needs-cherry-pick-3.1 needs-cherry-pick-master Should cherry pick this PR to master branch. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Mar 1, 2021
@ti-srebot
Copy link
Contributor

@XuHuaiyu, PTAL.

XuHuaiyu
XuHuaiyu reviewed Mar 4, 2021
View reviewed changes
literal-values.md Outdated
@@ -169,7 +169,7 @@ X'1z' (z 不是合法的十六进制值)
0X12AC (0X 必须用小写的 0x)
```

对于使用 `X'val'` 格式的十六进制字面值，`val` 必须要有一个数字，可以在前面补一个 0 来避免语法错误。
对于使用 `X'val'` 格式的十六进制字面值，`val` 必须要有一个数字，如果数字的长度是奇数（比如X'A',X'11A'），可以在前面补一个 0 来避免语法错误。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数字的长度 --> val 的长度?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数字的长度 --> val 的长度?

I have changed "数字的长度" to "val的长度".

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Mar 4, 2021
@ti-srebot
Copy link
Contributor

@zoujia-cm, please update your pull request.

@ti-srebot
Copy link
Contributor

@XuHuaiyu, PTAL.

@zoujia-cm
Copy link
Author

/cc @XuHuaiyu PTAL.

@zoujia-cm
Copy link
Author

/cc @XuHuaiyu PTAL

@TomShawn TomShawn requested a review from XuHuaiyu March 9, 2021 02:07
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #6068

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@zoujia-cm @ti-srebot
cherry pick pingcap#5620 to release-3.0
53c7855 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #6069

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@zoujia-cm @ti-srebot
cherry pick pingcap#5620 to release-3.1
dd6382e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #6070

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@zoujia-cm @ti-srebot
cherry pick pingcap#5620 to release-4.0
41d5713 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6071

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@zoujia-cm @ti-srebot
cherry pick pingcap#5620 to master
52b027e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #6072

@yikeke yikeke removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add details for Hexadecimal Literals (#5620) (#6069)
43b4536
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add details for Hexadecimal Literals (#5620) (#6070)
533867a
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add details for Hexadecimal Literals (#5620) (#6072)
21f37fe
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add details for Hexadecimal Literals (#5620) (#6071)
cc6abe6
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add details for Hexadecimal Literals (#5620) (#6068)
dc54303
@Joyinqin Joyinqin mentioned this pull request Apr 21, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 21, 2021
This was referenced Apr 26, 2021
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees

@Joyinqin Joyinqin

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zoujia-cm @CLAassistant @TomShawn @ti-srebot @XuHuaiyu @ti-chi-bot @yikeke @Joyinqin