Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of feedback-probability #4331

Merged
merged 6 commits into from
Sep 8, 2020
Merged

Change the default value of feedback-probability #4331

merged 6 commits into from
Sep 8, 2020

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 25, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

feedback-probability 的默认值说明有误

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

SunRunAway
SunRunAway reviewed Aug 25, 2020
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Aug 26, 2020
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/require-change Needs the author to address comments. translation/doing This PR’s assignee is translating this PR. labels Aug 26, 2020
@TomShawn
Copy link
Contributor

@winoros 需要改 v3.1/v3.0/v2.1 吗？这三个版本也有一样的描述。

@TomShawn TomShawn changed the title 统计信息：修正 feedback-probability 的默认值说明 Change the default value of feedback-probability Aug 26, 2020
@ti-srebot
Copy link
Contributor

@winoros, please update your pull request.

2 similar comments
@ti-srebot
Copy link
Contributor

@winoros, please update your pull request.

@ti-srebot
Copy link
Contributor

@winoros, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/require-change Needs the author to address comments. labels Sep 2, 2020
@ti-srebot
Copy link
Contributor

@winoros, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@winoros, please update your pull request.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/require-change Needs the author to address comments. labels Sep 8, 2020
@winoros @SunRunAway
Update statistics.md
8c790b2 
Co-authored-by: Feng Liyuan <[email protected]>
SunRunAway
SunRunAway reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@SunRunAway,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn reviewed Sep 8, 2020
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Sep 8, 2020
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Sep 8, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 5e764d4 into pingcap:master Sep 8, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 8, 2020
@winoros @ti-srebot
cherry pick pingcap#4331 to release-2.1
3991184 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4457

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 8, 2020
@winoros @ti-srebot
cherry pick pingcap#4331 to release-3.0
1d0f8bc 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4458

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 8, 2020
@winoros @ti-srebot
cherry pick pingcap#4331 to release-3.1
d3be3c1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4459

TomShawn pushed a commit that referenced this pull request Sep 8, 2020
@ti-srebot @winoros
cherry pick #4331 to release-2.1 (#4457)
8f83ce0 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Yiding Cui <[email protected]>
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 8, 2020
@winoros @ti-srebot
cherry pick pingcap#4331 to release-4.0
e963bab 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4460

TomShawn pushed a commit that referenced this pull request Sep 8, 2020
@ti-srebot @winoros
cherry pick #4331 to release-3.0 (#4458)
a0f26fe 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Yiding Cui <[email protected]>
TomShawn pushed a commit that referenced this pull request Sep 8, 2020
@ti-srebot @winoros
cherry pick #4331 to release-3.1 (#4459)
e47acbd 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Yiding Cui <[email protected]>
TomShawn pushed a commit that referenced this pull request Sep 8, 2020
@ti-srebot @winoros
cherry pick #4331 to release-4.0 (#4460)
7c174f4 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Yiding Cui <[email protected]>
@Joyinqin Joyinqin mentioned this pull request Sep 11, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 11, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Sep 11, 2020
This was referenced Sep 14, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @TomShawn @ti-srebot @Joyinqin @SunRunAway