Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add document of tispark support in tiup cluster #3963

Merged
merged 7 commits into from
Jul 31, 2020
Merged

tiup: add document of tispark support in tiup cluster #3963

merged 7 commits into from
Jul 31, 2020

Conversation

AstroProfundis
Copy link
Contributor

What is changed, added or deleted? (Required)

Add documentations of (experimental) support of TiSpark in TiUP Cluster. It should be merged after pingcap/tiup#531 is released.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@AstroProfundis AstroProfundis added the type/enhancement The issue or PR belongs to an enhancement. label Jul 14, 2020
@AstroProfundis AstroProfundis requested a review from lucklove July 14, 2020 07:05
@AstroProfundis AstroProfundis self-assigned this Jul 14, 2020
lucklove
lucklove approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lucklove,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

lucklove
lucklove approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lucklove,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. translation/doing This PR’s assignee is translating this PR. labels Jul 20, 2020
@ti-srebot
Copy link
Contributor

@lonng,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

yikeke
yikeke reviewed Jul 30, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jul 30, 2020
yikeke
yikeke reviewed Jul 31, 2020
View reviewed changes
tiup/tiup-cluster.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 31, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 31, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2020
@yikeke yikeke added the priority/P1 The issue has P1 priority. label Jul 31, 2020
@yikeke yikeke assigned TomShawn and unassigned AstroProfundis Jul 31, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a879482 into pingcap:master Jul 31, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 31, 2020
@AstroProfundis @ti-srebot
cherry pick pingcap#3963 to release-4.0
bc86086 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4136

yikeke pushed a commit that referenced this pull request Jul 31, 2020
@ti-srebot @AstroProfundis
cherry pick #3963 to release-4.0 (#4136)
7a09901 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Allen Zhong <[email protected]>
@yikeke yikeke removed status/require-change Needs the author to address comments. type/enhancement The issue or PR belongs to an enhancement. labels Jul 31, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 11, 2020
@TomShawn TomShawn mentioned this pull request Aug 11, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@lucklove lucklove lucklove approved these changes

@lonng lonng lonng approved these changes

Assignees

@TomShawn TomShawn

Labels
priority/P1 The issue has P1 priority. require-LGT1 Indicates that the PR requires an LGTM. size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AstroProfundis @ti-srebot @yikeke @lonng @lucklove @TomShawn