Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add sequence doc #2282

Merged
merged 10 commits into from
Feb 27, 2020
Merged

sql: add sequence doc #2282

merged 10 commits into from
Feb 27, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 24, 2020 •
edited by yikeke
Loading

What is changed, added or deleted?

add sequence doc for the sequence future in v.40.

What is the related PR or file link(s)?

  • Reference link(s): #14731, #14589, #14829...
  • This PR is to align with:
  • N/A (not applicable)

Important Notice:

If your changes apply to multiple TiDB documentation versions, to trigger the bot to cherry-pick this PR to other release branches, make sure you add labels such as:

  • NO

@yikeke yikeke added dev v4.0 This PR/issue applies to TiDB v4.0. translation/doing This PR’s assignee is translating this PR. labels Feb 24, 2020
AilinKid
AilinKid commented Feb 24, 2020
View reviewed changes
Copy link
Contributor Author

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deardrops
Deardrops reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在文档中说明一下我们的 sequence 语法与哪个数据库兼容么？

reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
reference/sql/statements/show-create-sequence.md Outdated Show resolved Hide resolved
Deardrops
Deardrops approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid merged commit 8a87a42 into pingcap:master Feb 27, 2020
@TomShawn TomShawn self-assigned this Feb 27, 2020
yikeke
yikeke reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. Rest LGTM

reference/sql/statements/create-sequence.md Show resolved Hide resolved
reference/sql/statements/create-sequence.md Show resolved Hide resolved
reference/sql/statements/create-sequence.md Show resolved Hide resolved
reference/sql/statements/create-sequence.md Show resolved Hide resolved
@TomShawn TomShawn mentioned this pull request Mar 5, 2020
Merged
4 tasks
@TomShawn TomShawn changed the title dev, v4.0: add sequence doc sql: add sequence doc Mar 5, 2020
@TomShawn TomShawn added the size/large Changes of a large size. label Mar 5, 2020
@TomShawn TomShawn mentioned this pull request Mar 11, 2020
Merged
4 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@Deardrops Deardrops Deardrops approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees

@TomShawn TomShawn

Labels
size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @Deardrops @yikeke @TomShawn