Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg: fix wrong pd-ctl cmd #18758

Merged
merged 2 commits into from
Oct 11, 2024
Merged

cfg: fix wrong pd-ctl cmd #18758

merged 2 commits into from
Oct 11, 2024

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Oct 9, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
@glkappe
Copy link
Contributor Author

glkappe commented Oct 9, 2024

wrong:
QQ_1728465489724
correct:
QQ_1728465448164

@hfxsd hfxsd self-assigned this Oct 9, 2024
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to use TiUP as it can manage versions, updates, etc. instead of directly calling a binary. But please make sure whatever you do matches the rest of the document

$ tiup ctl:v8.3.0 pd cluster
Starting component ctl: /home/dvaneeden/.tiup/components/ctl/v8.3.0/ctl pd cluster
{
  "id": 7423704173585173569,
  "max_peer_count": 3
}

Did the command change or was it always wrong?

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 9, 2024
@glkappe
Copy link
Contributor Author

glkappe commented Oct 10, 2024

I think it would be better to use TiUP as it can manage versions, updates, etc. instead of directly calling a binary. But please make sure whatever you do matches the rest of the document

$ tiup ctl:v8.3.0 pd cluster
Starting component ctl: /home/dvaneeden/.tiup/components/ctl/v8.3.0/ctl pd cluster
{
  "id": 7423704173585173569,
  "max_peer_count": 3
}

Did the command change or was it always wrong?

  1. Just modified the wrong command
  2. All the commands in this document are called binary files. This may be a good opportunity to modify them. . .
  3. Maybe I can start a new PR to make changes instead of this one, what do you think? @dveeden

@dveeden
Copy link
Contributor

dveeden commented Oct 10, 2024

@glkappe yes perfect!

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 08:06:29.774569759 +0000 UTC m=+1119745.194782767: ☑️ agreed by hfxsd.

configure-placement-rules.md Outdated Show resolved Hide resolved
@hfxsd hfxsd changed the title Wrong command cfg: fix wrong pd-ctl cmd Oct 11, 2024
@hfxsd hfxsd mentioned this pull request Oct 11, 2024
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. lgtm and removed translation/doing This PR’s assignee is translating this PR. labels Oct 11, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 11, 2024

/approve

Copy link

ti-chi-bot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6bd2069 into pingcap:master Oct 11, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18777.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18778.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18779.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18780.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18781.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants