Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc for Pipelined DML #16713

Merged
merged 28 commits into from
Mar 20, 2024
Merged

Doc for Pipelined DML #16713

merged 28 commits into from
Mar 20, 2024

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Mar 1, 2024 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a system variable tidb_dml_type.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2024
@ekexium ekexium requested review from Oreoxmt, you06 and joey-yez March 1, 2024 02:34
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. v8.0 This PR/issue applies to TiDB v8.0. labels Mar 1, 2024
@Oreoxmt Oreoxmt self-assigned this Mar 1, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 1, 2024
AndreMouche
AndreMouche reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 5, 2024
Oreoxmt
Oreoxmt reviewed Mar 7, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
@Oreoxmt Oreoxmt requested a review from hfxsd March 7, 2024 06:38
@Oreoxmt Oreoxmt mentioned this pull request Mar 7, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 7, 2024
hfxsd
hfxsd reviewed Mar 7, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
ekexium
ekexium commented Mar 7, 2024
View reviewed changes
configure-memory-usage.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
Oreoxmt
Oreoxmt reviewed Mar 14, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ekexium
Copy link
Member Author

ekexium commented Mar 14, 2024

LGTM

Oreoxmt
Oreoxmt reviewed Mar 14, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 14, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Mar 15, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ekexium ekexium requested a review from cfzjywxk March 19, 2024 02:19
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

@you06: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cfzjywxk
cfzjywxk reviewed Mar 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Mar 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 20, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 87eb722 into pingcap:master Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@cfzjywxk cfzjywxk cfzjywxk left review comments

@you06 you06 you06 approved these changes

@joey-yez joey-yez Awaiting requested review from joey-yez

@AndreMouche AndreMouche Awaiting requested review from AndreMouche

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0 This PR/issue applies to TiDB v8.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ekexium @Oreoxmt @AndreMouche @cfzjywxk @you06 @hfxsd