Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hardware requirement for disaggregated tiflash #16707

Merged
merged 20 commits into from
Mar 12, 2024
Merged

update hardware requirement for disaggregated tiflash #16707

merged 20 commits into from
Mar 12, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Feb 29, 2024 •
edited by JaySon-Huang
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 29, 2024
@guo-shaoge
fix link
3a2f473 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix blank
66c3f82 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix blank
9140abf 
Signed-off-by: guo-shaoge <[email protected]>
@Oreoxmt Oreoxmt mentioned this pull request Mar 1, 2024
Merged
18 tasks
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 1, 2024

/cc @joey-yez

@ti-chi-bot ti-chi-bot bot requested a review from joey-yez March 1, 2024 02:50
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 1, 2024
@JaySon-Huang JaySon-Huang changed the title update hardare requirement for disaggregated tiflash update hardware requirement for disaggregated tiflash Mar 1, 2024
zanmato1984
zanmato1984 requested changes Mar 4, 2024
View reviewed changes
hardware-and-software-requirements.md Outdated Show resolved Hide resolved
hardware-and-software-requirements.md Outdated Show resolved Hide resolved
hardware-and-software-requirements.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 4, 2024

@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guo-shaoge and others added 4 commits March 8, 2024 11:43
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 06:07:21.094952264 +0000 UTC m=+752068.117198652: ☑️ agreed by hfxsd.
  • 2024-03-12 06:34:55.518829635 +0000 UTC m=+753722.541076023: ☑️ agreed by Oreoxmt.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 12, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 12, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit 61c2515 into pingcap:master Mar 12, 2024
7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 12, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#16707
2ac5432 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16809.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 12, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#16707
ebb7dec 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16810.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16811.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 12, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#16707
9b320ec 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16812.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2024
Merged
18 tasks
Oreoxmt pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 13, 2024
@guo-shaoge @Oreoxmt
update hardware requirement for disaggregated tiflash (pingcap#16707)
cba0fc1
Oreoxmt pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 13, 2024
@guo-shaoge @Oreoxmt
update hardware requirement for disaggregated tiflash (pingcap#16707)
61ead1e
Oreoxmt pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 13, 2024
@guo-shaoge @Oreoxmt
update hardware requirement for disaggregated tiflash (pingcap#16707)
3d9ce55
ti-chi-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@ti-chi-bot
update hardware requirement for disaggregated tiflash (#16707) (#16811)
9f0dd6c
ti-chi-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@ti-chi-bot
update hardware requirement for disaggregated tiflash (#16707) (#16812)
39a459f
ti-chi-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@ti-chi-bot
update hardware requirement for disaggregated tiflash (#16707) (#16810)
7c41578
ti-chi-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@ti-chi-bot
update hardware requirement for disaggregated tiflash (#16707) (#16809)
1a31fd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@joey-yez joey-yez Awaiting requested review from joey-yez

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guo-shaoge @Oreoxmt @ti-chi-bot @zanmato1984 @JaySon-Huang @hfxsd