Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-index: remove the description that no stats are collected for mv index #16472

Merged

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 1, 2024

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0 This PR/issue applies to TiDB v8.0. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@Oreoxmt Oreoxmt self-assigned this Feb 1, 2024
@Oreoxmt Oreoxmt force-pushed the revert-16246-revert-15945-s18-s20-mv-index-estimation branch from cae6316 to 0e0053d Compare February 1, 2024 09:06
@Oreoxmt Oreoxmt requested a review from time-and-fate February 1, 2024 09:08
Copy link

ti-chi-bot bot commented Feb 6, 2024

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 29, 2024

/cc @hfxsd

@ti-chi-bot ti-chi-bot bot requested a review from hfxsd February 29, 2024 09:47
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 29, 2024
Copy link

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 10:38:22.179516253 +0000 UTC m=+1131190.927139364: ☑️ agreed by hfxsd.

@Oreoxmt Oreoxmt added the lgtm label Mar 19, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 19, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit b7c1713 into master Mar 19, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-16246-revert-15945-s18-s20-mv-index-estimation branch March 19, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0 This PR/issue applies to TiDB v8.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants