Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiup-cluster-topology-reference.md #12099

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Update tiup-cluster-topology-reference.md #12099

merged 2 commits into from
Nov 24, 2022

Conversation

srstack
Copy link
Contributor

@srstack srstack commented Nov 23, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@srstack srstack requested a review from qqqdan November 23, 2022 10:04
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2022
@srstack srstack self-assigned this Nov 23, 2022
@srstack srstack added area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. status/can-merge Indicates a PR has been approved by a committer. labels Nov 23, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2022
@srstack srstack added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 24, 2022
@shichun-0415
Copy link
Contributor

shichun-0415 commented Nov 24, 2022

@srstack Thanks for your contribution. FYI: GitHub does not support modifying the status label manually. We can only merge a PR after it obtains 2 LGTMs by using the /merge command. And only docs committers can merge PRs in docs repo. We will merge this PR ASAP after it passes both tech review and editorial review.

@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. type/bugfix This PR fixes a bug. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 24, 2022
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12113.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12114.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12115.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12116.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12117.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12118.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants