Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: add rank-formula-version config for hot scheduler #11566

Merged
merged 7 commits into from
Oct 18, 2022

Conversation

HunDunDM
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add description to the rank-formula-version config of PD's balance-hot-region-scheduler.

Related PD PR: pd#5515

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn October 10, 2022 10:58
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn October 10, 2022 11:01
@Oreoxmt Oreoxmt self-assigned this Oct 10, 2022
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Oct 10, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 10, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 11, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2022
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review October 11, 2022 02:33
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2022
@Oreoxmt Oreoxmt requested a review from shichun-0415 October 12, 2022 02:37
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@shichun-0415
Copy link
Contributor

shichun-0415 commented Oct 12, 2022

@HunDunDM Please help add the experimental feature to the experimental features file. Thanks.

experimental-features.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 18, 2022
@Oreoxmt Oreoxmt requested a review from shichun-0415 October 18, 2022 02:30
experimental-features.md Outdated Show resolved Hide resolved
experimental-features.md Outdated Show resolved Hide resolved
experimental-features.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 903ef35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2022
@ti-chi-bot ti-chi-bot merged commit 009dbba into pingcap:master Oct 18, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11671.

@Oreoxmt Oreoxmt removed the v6.4 This PR/issue applies to TiDB v6.4. label Oct 18, 2022
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants