Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: Add instructions to improve replica sync performance #11405

Merged
merged 5 commits into from
Oct 17, 2022
Merged

tiflash: Add instructions to improve replica sync performance #11405

merged 5 commits into from
Oct 17, 2022

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Sep 23, 2022 •
edited
Loading

Signed-off-by: Wish [email protected]

What is changed, added or deleted? (Required)

Add some instructions about how to sync TiFlash replica faster.

As this doc relies on some features not published yet, the instruction only applies to master branch.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 23, 2022 14:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2022
@breezewish
Copy link
Member Author

@JaySon-Huang @flowbehappy Could you take a look and leave your comments about what you think of this instruction? Thanks a lot!

@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 26, 2022
shichun-0415
shichun-0415 reviewed Oct 9, 2022
View reviewed changes
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Show resolved Hide resolved
@breezewish breezewish mentioned this pull request Oct 17, 2022
Merged
12 tasks
shichun-0415
shichun-0415 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2022
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 17, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7921e5b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2022
@ti-chi-bot ti-chi-bot merged commit 272d4dc into master Oct 17, 2022
@shichun-0415 shichun-0415 deleted the wenxuan/faster-tiflash-replica-sync branch October 17, 2022 04:07
This was referenced Nov 3, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@breezewish breezewish mentioned this pull request Nov 22, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 22, 2022
This was referenced Nov 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@breezewish breezewish

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@breezewish @ti-chi-bot @shichun-0415 @flowbehappy @TomShawn