Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config: fix binlog-gtid verify #983

Merged
merged 4 commits into from
Sep 3, 2020
Merged

config: fix binlog-gtid verify #983

merged 4 commits into from
Sep 3, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Sep 3, 2020 •
edited
Loading

What problem does this PR solve?

fix #978

What is changed and how it works?

check binlog-gtid in Verify.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 3, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 3, 2020
@lance6716
Copy link
Collaborator

make terror. but seems test check of CI printing usage message 🤔

https://internal.pingcap.net/idc-jenkins/blue/rest/organizations/jenkins/pipelines/dm_ghpr_test/runs/6540/nodes/93/steps/183/log/?start=0

lance6716
lance6716 reviewed Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this PR solve origin issue

dm/config/task_test.go Outdated Show resolved Hide resolved
@csuzhangxc
Copy link
Member Author

not sure how this PR solve origin issue

I tiny updated the origin issue.

previous, specify binlog-gtid without binlog-name will return the error; now, the user can only specify binlog-gtid (without binlog-name).

@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 3, 2020
GMHDBJD
GMHDBJD approved these changes Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 3, 2020
@csuzhangxc csuzhangxc merged commit 32be8b6 into pingcap:master Sep 3, 2020
@csuzhangxc csuzhangxc deleted the fix-978 branch September 3, 2020 10:42
@ti-srebot ti-srebot mentioned this pull request Sep 3, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #987

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 3, 2020
csuzhangxc pushed a commit that referenced this pull request Sep 3, 2020
@ti-srebot
config: fix binlog-gtid verify (#983) (#987)
18852db
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

"binlog-name must specify" reported when binlog-gtid specified
4 participants
@csuzhangxc @lance6716 @ti-srebot @GMHDBJD