Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update tidb (fix print massive log) and parser #968

Merged
merged 6 commits into from
Sep 2, 2020
Merged

dep: update tidb (fix print massive log) and parser #968

merged 6 commits into from
Sep 2, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

port TiDB pingcap/tidb#18844

update parser to https://github.com/pingcap/tidb/blob/f82e5320ad75442f8f9dd76316ef20b1707386ee/go.mod#L39

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716
Copy link
Collaborator Author

lance6716 commented Sep 1, 2020 •
edited
Loading

note: could revert schema tracker part of #801 in this PR or another.

@lance6716 lance6716 added dependencies Pull requests that update a dependency file needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 1, 2020
@csuzhangxc
Copy link
Member

note: could revert schema tracker part of #801 in this PR or another.

we can revert part of #801 later because not all of users will upgrade TiDB to the newest version recently.

@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Sep 1, 2020
@lance6716
Copy link
Collaborator Author

note: could revert schema tracker part of #801 in this PR or another.

we can revert part of #801 later because not all of users will upgrade TiDB to the newest version recently.

Only the schema tracker part (updated PR comment). Downstream part will keep because auto-drop is triggered by downtream error message

csuzhangxc
csuzhangxc previously approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 1, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@csuzhangxc csuzhangxc removed this from the v2.0.0 RC.2 milestone Sep 1, 2020
@lance6716 lance6716 added the status/DNM Do not merge, test is failing or blocked by another PR label Sep 2, 2020
@lance6716 lance6716 changed the base branch from master to update-tidb September 2, 2020 03:42
@lance6716 lance6716 merged commit c99e0ec into pingcap:update-tidb Sep 2, 2020
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2020
Closed
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #976

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 2, 2020
@lance6716 lance6716 removed already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked dependencies Pull requests that update a dependency file needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM labels Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

Assignees
No one assigned
Labels
status/DNM Do not merge, test is failing or blocked by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @csuzhangxc @ti-srebot