Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dumpling: compatibility for --no-locks (#958) #961

Merged
merged 4 commits into from
Aug 31, 2020
Merged

dumpling: compatibility for --no-locks (#958) #961

merged 4 commits into from
Aug 31, 2020

Conversation

ti-srebot
Copy link

cherry-pick #958 to release-2.0

What problem does this PR solve?

close #956

What is changed and how it works?

replace --no-locks in parseExtraArgs

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 31, 2020
csuzhangxc
csuzhangxc approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Aug 31, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 31, 2020
@csuzhangxc csuzhangxc merged commit 4e7e3d1 into pingcap:release-2.0 Aug 31, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @csuzhangxc @lance6716