Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

basedb: close db when fail ping #942

Merged
merged 3 commits into from
Aug 28, 2020
Merged

basedb: close db when fail ping #942

merged 3 commits into from
Aug 28, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Aug 28, 2020 •
edited
Loading

What problem does this PR solve?

DB connection leak when successful open DB but failed ping.

What is changed and how it works?

close it manually. alternative is we should return db, error to caller instead of nil, error, so caller's rollback function could handle closing DB.

Check List

Tests

  • unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Aug 28, 2020
@lance6716 lance6716 requested a review from GMHDBJD August 28, 2020 02:55
@lance6716 lance6716 added status/WIP This PR is still work in progress and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 28, 2020
@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Aug 28, 2020
GMHDBJD
GMHDBJD reviewed Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 28, 2020
csuzhangxc
csuzhangxc approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 28, 2020
@lance6716 lance6716 merged commit be3c77b into pingcap:master Aug 28, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@ti-srebot ti-srebot mentioned this pull request Aug 28, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #943

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 28, 2020
lance6716 pushed a commit that referenced this pull request Aug 28, 2020
@ti-srebot
basedb: close db when fail ping (#942) (#943)
c8f2949
@lance6716 lance6716 deleted the close-db branch August 28, 2020 05:55
lance6716 added a commit to lance6716/dm that referenced this pull request Aug 28, 2020
@lance6716
basedb: close db when fail ping (pingcap#942)
f518b52 
* basedb: close db when fail ping

* fix unregister TLS

* add unit test
@lance6716 lance6716 mentioned this pull request Aug 28, 2020
Merged
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Aug 28, 2020
csuzhangxc pushed a commit that referenced this pull request Aug 28, 2020
@lance6716
basedb: close db when fail ping (#942) (#945)
4992971
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD