This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker: avoid illegal zero value of channel #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/unimportant
lichunzhu
reviewed
Aug 6, 2020
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
================================================
+ Coverage 56.0760% 56.1048% +0.0287%
================================================
Files 214 220 +6
Lines 22712 22859 +147
================================================
+ Hits 12736 12825 +89
- Misses 8665 8726 +61
+ Partials 1311 1308 -3 |
GMHDBJD
added
status/LGT1
too many channels to check 😂 we're going to do it when refactoring |
lichunzhu
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #869
What is changed and how it works?
check
_, ok <-chan(we may need to check more channel)Check List
Tests
Code changes
Side effects
Related changes