Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

feat: upgrade v1.0.x metadata tables #858

Merged
merged 13 commits into from
Aug 5, 2020
Merged

feat: upgrade v1.0.x metadata tables #858

merged 13 commits into from
Aug 5, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

part of #774.

What is changed and how it works?

  • add columns for syncer checkpoint
  • update column values for syncer checkpoint
  • update column values for online DDL meta

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

@csuzhangxc csuzhangxc added priority/important Major change, requires approval from ≥2 primary reviewers needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/WIP This PR is still work in progress type/feature New feature labels Aug 4, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Aug 4, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Aug 5, 2020
@csuzhangxc csuzhangxc requested review from GMHDBJD and lance6716 August 5, 2020 06:19
lance6716
lance6716 reviewed Aug 5, 2020
View reviewed changes
pkg/v1dbschema/schema_test.go Outdated Show resolved Hide resolved
pkg/binlog/reader/util.go Show resolved Hide resolved
pkg/binlog/reader/util.go Outdated Show resolved Hide resolved
pkg/v1dbschema/schema.go Show resolved Hide resolved
pkg/v1dbschema/schema.go Outdated Show resolved Hide resolved
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Aug 5, 2020
@lance6716 lance6716 removed the status/PTAL This PR is ready for review. Add this label back after committing new changes label Aug 5, 2020
GMHDBJD
GMHDBJD approved these changes Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 5, 2020
@csuzhangxc csuzhangxc merged commit d71b25d into pingcap:master Aug 5, 2020
@csuzhangxc csuzhangxc deleted the v1-schema branch August 5, 2020 09:49
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/important Major change, requires approval from ≥2 primary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @lance6716 @GMHDBJD @ti-srebot