-
Notifications
You must be signed in to change notification settings - Fork 188
mydumper, worker: don't auto-resume when can't acquire global lock #857
Conversation
YES. all errors in all branches should always be the same, and in fact, before releasing any version, we must ensure errros codes have synced between branches. |
BTW, does the master branch (with the newest dumpling) has this problem? |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #857 +/- ##
===================================================
- Coverage 57.6815% 57.6677% -0.0138%
===================================================
Files 168 168
Lines 16761 16765 +4
===================================================
Hits 9668 9668
- Misses 6210 6214 +4
Partials 883 883 |
if this fail is caused by lack of RELOAD privilege, dumpling could keep pause.
but we can't simulate other fail reason |
OK, we can only fix it in release-1.0 now. |
tests/full_mode/run.sh
Outdated
check_log_contains $WORK_DIR/worker2/log/dm-worker.log "Couldn't acquire global lock" | ||
run_dm_ctl $WORK_DIR "127.0.0.1:$MASTER_PORT" \ | ||
"query-status test" \ | ||
"\"stage\": \"Paused\"" 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check error message and workaround here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8c017f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
close #837
What is changed and how it works?
add a terror and check it in
isResumableError
Check List
Tests
Code changes
Side effects
Related changes
- need cherry-pick terror to master