This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/important
Major change, requires approval from ≥2 primary reviewers
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
status/WIP
This PR is still work in progress
labels
Jul 31, 2020
csuzhangxc
reviewed
Jul 31, 2020
lance6716
reviewed
Aug 3, 2020
lance6716
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update PR's description to help me understand 🤣
/run-all-tests |
lance6716
reviewed
Aug 11, 2020
lance6716
reviewed
Aug 12, 2020
"github.com/pingcap/parser" | ||
"github.com/pingcap/parser/ast" | ||
tmysql "github.com/pingcap/parser/mysql" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
I found in other code we don't need to split 3-rd package from pingcap and others.
LGTM |
lance6716
removed
the
status/PTAL
This PR is ready for review. Add this label back after committing new changes
label
Aug 12, 2020
csuzhangxc
reviewed
Aug 13, 2020
/run-all-tests |
csuzhangxc
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cooooooool
csuzhangxc
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Aug 13, 2020
6 tasks
docs PR pingcap/docs-dm#227 |
csuzhangxc
added
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
and removed
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
labels
Aug 14, 2020
csuzhangxc
removed
the
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
label
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
priority/important
Major change, requires approval from ≥2 primary reviewers
status/LGT2
Two reviewers already commented LGTM, ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
handle --binlog-pos startLocation skip
or change the checkpoint with endLocation to skip event.Check List
Tests