Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: add metrics for optimistic shard DDL lock #831

Merged
merged 2 commits into from
Jul 28, 2020
Merged

*: add metrics for optimistic shard DDL lock #831

merged 2 commits into from
Jul 28, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jul 27, 2020 •
edited
Loading

What problem does this PR solve?

part of #543

What is changed and how it works?

add metrics for optimistic shard DDL lock, and some renames because we call metrics.ReportDDLPending so don't repeat ...ToMetric

Check List

Tests

  • Manual test (pause sequence_sharding_optimistic and check grafana)

Code changes

  • Has exported function/method change

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/feature New feature status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020 •
edited
Loading

Codecov Report

Merging #831 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #831   +/-   ##
===========================================
  Coverage   56.1151%   56.1151%           
===========================================
  Files           212        212           
  Lines         22199      22199           
===========================================
  Hits          12457      12457           
  Misses         8519       8519           
  Partials       1223       1223

csuzhangxc
csuzhangxc approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 28, 2020
@lance6716 lance6716 merged commit ea7bd30 into pingcap:master Jul 28, 2020
@lance6716 lance6716 deleted the opti-lock-status branch July 28, 2020 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.
2 participants
@lance6716 @csuzhangxc