This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: change panels for loader, dumpling #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/normal
GMHDBJD
added
status/LGT1
csuzhangxc
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
===========================================
Coverage 56.0077% 56.0077%
===========================================
Files 212 212
Lines 22113 22113
===========================================
Hits 12385 12385
Misses 8508 8508
Partials 1220 1220 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #543
What is changed and how it works?
for loader and mydumper/dumpling, add
source_idlabel for every metrics (except forstmtHistogram, which used by DB connection functions and shared by other logic)change some panels to use
source_idfilterCheck List
Tests
Code changes
Side effects
Related changes