Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: add metrics #772

Merged
merged 6 commits into from
Jul 3, 2020
Merged

worker: add metrics #772

merged 6 commits into from
Jul 3, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

part of #543

What is changed and how it works?

add/modify two types of metrics:

  • add label source_id for state of subtasks
  • add counter of number of operate errors by (worker, error type), remove all TODO: add better metrics

Check List

Tests

  • pass original tests

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression

Related changes

@ti-srebot ti-srebot added the contribution For contributor label Jul 1, 2020
@lance6716 lance6716 mentioned this pull request Jul 1, 2020
Closed
@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature status/WIP This PR is still work in progress and removed contribution For contributor labels Jul 1, 2020
@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #772   +/-   ##
===========================================
  Coverage   57.0879%   57.0879%           
===========================================
  Files           206        206           
  Lines         21339      21339           
===========================================
  Hits          12182      12182           
  Misses         7968       7968           
  Partials       1189       1189

WangXiangUSTC
WangXiangUSTC reviewed Jul 2, 2020
View reviewed changes
dm/worker/metrics.go Outdated Show resolved Hide resolved
dm/worker/worker.go Outdated Show resolved Hide resolved
dm/worker/metrics.go Show resolved Hide resolved
WangXiangUSTC
WangXiangUSTC reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 3, 2020
GMHDBJD
GMHDBJD approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 381f202 into pingcap:master Jul 3, 2020
@lance6716 lance6716 deleted the fix543-1 branch July 3, 2020 05:26
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 15, 2020
@lance6716 lance6716 mentioned this pull request Jul 15, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @WangXiangUSTC @GMHDBJD @csuzhangxc @ti-srebot