Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: cherry pick 741; update terror codes #742

Merged
merged 7 commits into from
Jun 17, 2020
Merged

*: cherry pick 741; update terror codes #742

merged 7 commits into from
Jun 17, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 16, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 16, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc csuzhangxc added status/WIP This PR is still work in progress and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 16, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=v4.0.0

@codecov
Copy link

codecov bot commented Jun 17, 2020 •
edited
Loading

Codecov Report

Merging #742 into release-1.0 will increase coverage by 0.6077%.
The diff coverage is 75.4216%.

@@                 Coverage Diff                 @@
##           release-1.0       #742        +/-   ##
===================================================
+ Coverage      57.2665%   57.8742%   +0.6077%     
===================================================
  Files              161        166         +5     
  Lines            16741      16992       +251     
===================================================
+ Hits              9587       9834       +247     
+ Misses            6206       6202         -4     
- Partials           948        956         +8

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=v4.0.0

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jun 17, 2020
@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @GMHDBJD PTAL

WangXiangUSTC
WangXiangUSTC reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 17, 2020
GMHDBJD
GMHDBJD approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 17, 2020
@csuzhangxc csuzhangxc merged commit ddb37ac into pingcap:release-1.0 Jun 17, 2020
@csuzhangxc csuzhangxc deleted the pick-741 branch June 17, 2020 02:53
@csuzhangxc csuzhangxc mentioned this pull request Jun 17, 2020
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @WangXiangUSTC @GMHDBJD