Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

don't resume task for unsupported collation error #735

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

cherry pick #732

What problem does this PR solve?

fix issue #709

What is changed and how it works?

add the error message to UnsupportedDDLMsgs list

@WangXiangUSTC WangXiangUSTC added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #735 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #735   +/-   ##
==============================================
  Coverage      57.8888%   57.8888%           
==============================================
  Files              166        166           
  Lines            16986      16986           
==============================================
  Hits              9833       9833           
  Misses            6199       6199           
  Partials           954        954           

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 15, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 15, 2020
@csuzhangxc csuzhangxc merged commit 5c16d69 into release-1.0 Jun 15, 2020
@csuzhangxc csuzhangxc deleted the xiang/pick-collation branch June 15, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants