Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: refine heartbeat (#704) #729

Merged
merged 1 commit into from
Jun 11, 2020
Merged

syncer: refine heartbeat (#704) #729

merged 1 commit into from
Jun 11, 2020

Conversation

csuzhangxc
Copy link
Member

cherry-pick #704 manually.

What problem does this PR solve?

What is changed and how it works?

  • compare heartbeat schema and table as case-insensitive
  • do not update replication lag metric if no valid slave ts exit
  • use UTC_TIMESTAMP(6) to replace UTC_TIMESTAMP()

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to be included in the release note

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 11, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 beta.2 milestone Jun 11, 2020
@WangXiangUSTC
Copy link
Contributor

/run-all-tests

GMHDBJD
GMHDBJD reviewed Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 11, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 11, 2020
@csuzhangxc csuzhangxc merged commit a6c877f into pingcap:master Jun 11, 2020
@csuzhangxc csuzhangxc deleted the pick-704 branch June 11, 2020 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0 beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @WangXiangUSTC @GMHDBJD