Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: fix new shard DDL handle when the previous one has not complete #725

Merged
merged 10 commits into from
Jun 12, 2020
Merged

*: fix new shard DDL handle when the previous one has not complete #725

merged 10 commits into from
Jun 12, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

fix #628

What is changed and how it works?

do not put shard DDL info if the done operation exists

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • Possible performance regression
  • Increased code complexity

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/bug-fix Bug fix labels Jun 8, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 beta.2 milestone Jun 8, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #725 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #725   +/-   ##
===========================================
  Coverage   57.0572%   57.0572%           
===========================================
  Files           205        205           
  Lines         21184      21184           
===========================================
  Hits          12087      12087           
  Misses         7923       7923           
  Partials       1174       1174

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jun 9, 2020
WangXiangUSTC
WangXiangUSTC reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 12, 2020
GMHDBJD
GMHDBJD approved these changes Jun 12, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 12, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc csuzhangxc merged commit d98acd9 into pingcap:master Jun 12, 2020
@csuzhangxc csuzhangxc deleted the fix-pess-new-ddl branch June 12, 2020 13:00
@GMHDBJD GMHDBJD mentioned this pull request Nov 2, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 beta.2
Development

Successfully merging this pull request may close these issues.

pessimistic shard DDL can't handle new DDL when the old one has not been resolved
3 participants
@csuzhangxc @WangXiangUSTC @GMHDBJD