This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
.*: add list-member command #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
GMHDBJD
added
status/PTAL
|
/run-all-tests |
GMHDBJD
added
status/WIP
GMHDBJD
added
status/PTAL
csuzhangxc
reviewed
May 13, 2020
dm/ctl/master/list_member.go
Outdated
| // NewListMemberCmd creates an ListMember command | ||
| func NewListMemberCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "list-member master/worker/leader", |
There was a problem hiding this comment.
Can we list all members if no more argument specified? in other words, make master/worker/leader become optional arg ([--master] [--worker] [--leader]).
dm/ctl/master/list_member.go
Outdated
Comment on lines
20
to
25
| "github.com/gogo/protobuf/proto" | ||
| "github.com/pingcap/dm/dm/ctl/common" | ||
| "github.com/pingcap/dm/dm/pb" | ||
|
|
||
| "github.com/pingcap/errors" | ||
| "github.com/spf13/cobra" |
There was a problem hiding this comment.
need to format these pkg
dm/master/server.go
Outdated
| return resp, nil | ||
| } | ||
|
|
||
| _, leaderName, _, err := s.election.LeaderInfo(ctx) |
There was a problem hiding this comment.
seems that the information returned by LeaderInfo is enough, don't need to query etcd again? and we can update the result of LeaderInfo if necessary
|
rest LGTM |
WangXiangUSTC
added
the
status/LGT2
|
/run-all-tests |
GMHDBJD
added
status/PTAL
csuzhangxc
reviewed
May 19, 2020
dm/ctl/master/list_member.go
Outdated
Comment on lines
37
to
39
| func (c ListMemberFlags) Reset() { | ||
| c.names = c.names[:0] | ||
| } |
There was a problem hiding this comment.
Is this necessary? and where do we call this Reset?
There was a problem hiding this comment.
Not necessary. I have removed it.
csuzhangxc
added
status/LGT1
lichunzhu
added
status/LGT2
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
This was referenced May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
some interface preview
Check List
Tests
Code changes