Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: update go mod #632

Merged
merged 5 commits into from
Apr 24, 2020
Merged

*: update go mod #632

merged 5 commits into from
Apr 24, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 23, 2020

What problem does this PR solve?

  • update pingcap/parser to improve compatibility.
  • update pingcap/tidb-tools to retry for ErrWriteConflictInTiDB and ErrWriteConflict.
    • also fix the schema/table name update of heartbeat

What is changed and how it works?

go get -u github.com/pingcap/parser@7329d80eaf2c
go get -u github.com/pingcap/pd/v4@428acd53eba2
go get github.com/pingcap/tidb-tools@efaa8b1028bc1164e40dac518dc4958fe00eabe3
go get github.com/pingcap/tidb@0ad7ce6cdae62b1a09491a159061df11d0f16e32
go mod tidy

go get -u github.com/pingcap/failpoint@f8f9fb234798 # new failpoint may lead to panic, downgrade to the version in TiDB
go mod tidy

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

Related changes

  • Need to be included in the release note

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/dependencies Pull requests that update a dependency file labels Apr 23, 2020
@csuzhangxc csuzhangxc added this to the v1.0.5 milestone Apr 23, 2020
@lichunzhu lichunzhu added the status/LGT1 One reviewer already commented LGTM label Apr 23, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #632 into release-1.0 will decrease coverage by 0.1020%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #632        +/-   ##
===================================================
- Coverage      57.9226%   57.8206%   -0.1021%     
===================================================
  Files              166        166                
  Lines            17002      16968        -34     
===================================================
- Hits              9848       9811        -37     
- Misses            6199       6207         +8     
+ Partials           955        950         -5     

@lichunzhu lichunzhu removed the status/PTAL This PR is ready for review. Add this label back after committing new changes label Apr 24, 2020
@WangXiangUSTC
Copy link
Contributor

LGTM

@lichunzhu lichunzhu added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 24, 2020
@csuzhangxc csuzhangxc merged commit 529646e into pingcap:release-1.0 Apr 24, 2020
@csuzhangxc csuzhangxc deleted the update-gomod branch April 24, 2020 08:34
@csuzhangxc csuzhangxc removed the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants