This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/PTAL
This PR is ready for review. Add this label back after committing new changes
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
type/dependencies
Pull requests that update a dependency file
labels
Apr 23, 2020
/run-all-tests |
1 similar comment
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #632 +/- ##
===================================================
- Coverage 57.9226% 57.8206% -0.1021%
===================================================
Files 166 166
Lines 17002 16968 -34
===================================================
- Hits 9848 9811 -37
- Misses 6199 6207 +8
+ Partials 955 950 -5 |
lichunzhu
removed
the
status/PTAL
This PR is ready for review. Add this label back after committing new changes
label
Apr 24, 2020
LGTM |
lichunzhu
approved these changes
Apr 24, 2020
lichunzhu
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Apr 24, 2020
2 tasks
2 tasks
csuzhangxc
removed
the
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
label
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pingcap/parser
to improve compatibility.pingcap/tidb-tools
to retry forErrWriteConflictInTiDB
andErrWriteConflict
.What is changed and how it works?
Check List
Tests
Side effects
Related changes