This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: fix generated column in where condition #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
amyangfei
added
status/PTAL
|
PTAL @GregoryIan @csuzhangxc |
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
IANTHEREAL
reviewed
Feb 27, 2019
syncer/dml.go
Outdated
|
|
||
| if len(defaultIndexColumns) == 0 { | ||
| defaultIndexColumns = getAvailableIndexColumn(indexColumns, oldValues) | ||
| defaultIndexColumns = getAvailableIndexColumn(originalIndexColumns, oriOldValues) | ||
| } | ||
|
|
||
| ks := genMultipleKeys(columns, oldValues, indexColumns) |
There was a problem hiding this comment.
should we use oriOldValues?
|
Rest LGTM |
|
PTAL @GregoryIan |
IANTHEREAL
reviewed
Feb 27, 2019
| sqls := make([]string, 0, len(dataSeq)) | ||
| keys := make([][]string, 0, len(dataSeq)) | ||
| values := make([][]interface{}, 0, len(dataSeq)) | ||
| columnList := genColumnList(columns) | ||
| columnPlaceholders := genColumnPlaceholders(len(columns)) | ||
| for _, data := range dataSeq { | ||
| for dataIdx, data := range dataSeq { | ||
| if len(data) != len(columns) { |
There was a problem hiding this comment.
also check originalColumns and originalDataSeq ?
There was a problem hiding this comment.
not needed, data/columns and origianlData/originalColumns have the same length distance ?
There was a problem hiding this comment.
add column and data length check in generated column prune
syncer/dml.go
Outdated
| @@ -140,16 +177,30 @@ func genUpdateSQLs(schema string, table string, data [][]interface{}, columns [] | |||
| changedValues = append(changedValues, castUnsigned(changedData[i], columns[i].unsigned, columns[i].tp)) | |||
| } | |||
|
|
|||
| oriOldValues := make([]interface{}, 0, len(oriOldData)) | |||
There was a problem hiding this comment.
genUpdateSQLs, `genInsertSQLs`` has these codes in same pattern:
...values
for i := range data {
values = append(values,....)
}
if len(columns) == len(originalColumns) {
originalVals = values
} else {
for {....}
}
can we extract it a function?
|
LGTM |
IANTHEREAL
added
status/LGT1
csuzhangxc
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently we remove all generated column for DML, but generated column in where condition is valid.
What is changed and how it works?
update/deleteDMLCheck List
Tests
Side effects