Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: make table name as the prefix of the key #588

Merged
merged 2 commits into from
Apr 9, 2020
Merged

syncer: make table name as the prefix of the key #588

merged 2 commits into from
Apr 9, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 9, 2020 •
edited
Loading

What problem does this PR solve?

disable conflict between different tables.

What is changed and how it works?

make table name as the prefix of the key

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to be included in the release note

@csuzhangxc csuzhangxc changed the title syncer: append schema and table to row key syncer: append schema and table name to row key Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #588 into release-1.0 will decrease coverage by 0.0119%.
The diff coverage is 100.0000%.

@@                 Coverage Diff                 @@
##           release-1.0       #588        +/-   ##
===================================================
- Coverage      57.2756%   57.2636%   -0.0120%     
===================================================
  Files              161        161                
  Lines            16672      16672                
===================================================
- Hits              9549       9547         -2     
- Misses            6181       6182         +1     
- Partials           942        943         +1

@csuzhangxc csuzhangxc changed the title syncer: append schema and table name to row key syncer: make table name as the prefix of the key Apr 9, 2020
@csuzhangxc csuzhangxc merged commit 562a126 into pingcap:release-1.0 Apr 9, 2020
@csuzhangxc csuzhangxc deleted the improve-key branch April 9, 2020 11:54
csuzhangxc added a commit to csuzhangxc/dm that referenced this pull request Apr 14, 2020
@csuzhangxc
syncer: make table name as the prefix of the key (pingcap#588)
c286b9c
@csuzhangxc csuzhangxc mentioned this pull request Apr 15, 2020
Merged
@csuzhangxc csuzhangxc added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer labels Apr 23, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csuzhangxc @IANTHEREAL