This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
.*/: fix dm unit tests and integration tests #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
the
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
================================================
+ Coverage 57.6975% 57.7998% +0.1022%
================================================
Files 200 200
Lines 20422 20244 -178
================================================
- Hits 11783 11701 -82
+ Misses 7472 7420 -52
+ Partials 1167 1123 -44 |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
lichunzhu
added
the
status/PTAL
lichunzhu
requested review from
WangXiangUSTC and
csuzhangxc
and removed request for
WangXiangUSTC
|
/run-all-tests |
csuzhangxc
added
status/LGT1
WangXiangUSTC
added
status/LGT2
csuzhangxc
pushed a commit
to csuzhangxc/dm
that referenced
this pull request
Apr 17, 2020
lichunzhu
added a commit
that referenced
this pull request
Apr 17, 2020
* feature: remove metrics when stopping task (#575) * .*/: fix dm unit tests and integration tests (#578) * tests: fix merge Co-authored-by: Amatist_Kurisu <[email protected]> Co-authored-by: Chunzhu Li <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR aims to fix wrong and unstable tests.
relay_interrupt,start_taskdon't clear databasedm_metaand relative database before each subtest. So the test result except the first one is meaningless,What is changed and how it works?
dm_metaand relative database before each subtest. Use different table name for each subtest.Check List
Tests
Related changes