Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-portal: add i18n support #476

Merged
merged 2 commits into from
Feb 14, 2020
Merged

dm-portal: add i18n support #476

merged 2 commits into from
Feb 14, 2020

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Feb 12, 2020 •
edited
Loading

What problem does this PR solve?

Add i18n support for DM Portal, satisfy #475 feature request.

3

What is changed and how it works?

You can choose which language want to use.

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Feb 13, 2020
csuzhangxc
csuzhangxc approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

1 similar comment
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #476 into master will decrease coverage by 0.0173%.
The diff coverage is 58.3333%.

@@               Coverage Diff                @@
##             master       #476        +/-   ##
================================================
- Coverage   57.3305%   57.3131%   -0.0174%     
================================================
  Files           167        167                
  Lines         17277      17277                
================================================
- Hits           9905       9902         -3     
- Misses         6402       6405         +3     
  Partials        970        970

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Feb 14, 2020
@WangXiangUSTC WangXiangUSTC merged commit e31e5de into master Feb 14, 2020
@WangXiangUSTC WangXiangUSTC deleted the dm-portal-i18n branch February 14, 2020 02:31
@sre-bot
Copy link

sre-bot commented Feb 14, 2020

cherry pick to release-1.0 failed

@csuzhangxc csuzhangxc removed the status/LGT1 One reviewer already commented LGTM label Feb 14, 2020
baurine added a commit that referenced this pull request Feb 14, 2020
@baurine
dm-portal: add i18n support (#476)
bd60d05
@baurine baurine mentioned this pull request Feb 14, 2020
Merged
@WangXiangUSTC WangXiangUSTC mentioned this pull request Feb 14, 2020
Closed
@csuzhangxc csuzhangxc added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Mar 13, 2020
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@baurine
dm-portal: add i18n support (pingcap#476)
c7dc870
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baurine @WangXiangUSTC @csuzhangxc @sre-bot