This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
ha: refactor the schedule model #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/important
csuzhangxc
changed the title
lichunzhu
reviewed
Feb 10, 2020
Co-Authored-By: WangXiangUSTC <[email protected]>
lichunzhu
reviewed
Feb 12, 2020
|
|
||
| // WatchSourceBound watches PUT & DELETE operations for the bound relationship of the specified DM-worker. | ||
| // For the DELETE operations, it returns an empty bound relationship. | ||
| func WatchSourceBound(ctx context.Context, cli *clientv3.Client, |
There was a problem hiding this comment.
Shall we return error for retry?
# Conflicts: # dm/common/common.go # pkg/ha/source_test.go
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
# Conflicts: # _utils/terror_gen/errors_release.txt # dm/master/coordinator/coordinator.go # dm/master/election.go # dm/master/server.go # pkg/terror/error_list.go # tests/ha/run.sh
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
the HA model before this PR can't tolerate well, and can't support pause-relay/pause-task correctly.
What is changed and how it works?
rewrite the HA mode, see pkg/ha/doc.go.
Check List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible