Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

ansible: update wrong error message (#437) #438

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Dec 19, 2019

cherry-pick #437 to release-1.0


What problem does this PR solve?

when users don't set prometheus host in inventory.ini, will print error messgae about dm-worker

What is changed and how it works?

fix this wrong message

Related changes

  • Need to cherry-pick to the release branch

@sre-bot sre-bot added priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 19, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@df2f4d7). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-1.0      #438   +/-   ##
===============================================
  Coverage               ?   57.111%           
===============================================
  Files                  ?       161           
  Lines                  ?     16601           
  Branches               ?         0           
===============================================
  Hits                   ?      9481           
  Misses                 ?      6185           
  Partials               ?       935

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Dec 19, 2019
@csuzhangxc csuzhangxc merged commit ddfd7de into pingcap:release-1.0 Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants