This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: fix DB connection close and all_mode integration test (#403) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-bot
added
priority/unimportant
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
added
the
needs-update-release-note
|
cherry-pick manually in #436. |
csuzhangxc
removed
the
needs-update-release-note
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #403 to release-1.0
What problem does this PR solve?
resume-taskmay fail becauseresetBaseConnFnreturning an invalid existing connection/tmp/dm_test/all_mode/worker1/log/dm-worker.log dosen't contain dispatch auto resume task.What is changed and how it works?
Check List
Tests
Related changes